Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-99 Support PlaceholderAPI Relational Placeholder #122

Merged

Conversation

Gertius
Copy link
Contributor

@Gertius Gertius commented May 12, 2024

Description

This PR resolves #99.

What kind of change does this PR introduce? (Check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build related changes
  • Documentation code
  • Other, please describe:

Make sure your PR fulfills these requirements:

  • Tests for the changes have been added (where possible)
  • Documentation (README.md, CONTRIBUTING.md) has been updated, if needed
  • All new and existing tests have passed

Other Information

N/A

Checklist

By submitting this PR, you confirm that you have completed the following:

  • I have read and understand the CONTRIBUTING Guide
  • I have checked that no existing PRs fulfill my requirements and appear to be duplicates
  • The PR title follows the guidelines defined in the contributing guide
  • All tests pass locally with my changes (if applicable)
  • I have performed a self-review of my own code

@Rollczi
Copy link
Member

Rollczi commented May 27, 2024

Hey @Gertius, Thanks for your pull request ❤️

Do you think these changes look okay to you?

@vLuckyyy vLuckyyy changed the title Support PlaceholderAPI Relational Placeholder GH-99 Support PlaceholderAPI Relational Placeholder May 29, 2024
@Gertius
Copy link
Contributor Author

Gertius commented Jun 1, 2024

@Rollczi Your changes look good!

@Rollczi Rollczi merged commit b364d55 into EternalCodeTeam:master Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Relational Placeholder Support.
3 participants