Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-125 expand default config and PlaceholderAPI support in internal placeholders #125

Merged
merged 7 commits into from
Jun 2, 2024

Conversation

Kamicjusz
Copy link
Contributor

This PR add support for PlaceholderAPI in intenal placeholders
also expand default plugin configuration

@Kamicjusz Kamicjusz requested review from vLuckyyy, Rollczi, igoyek, Jakubk15, P1otrulla, CitralFlo and Kazaruma and removed request for vLuckyyy May 24, 2024 12:54
@Kamicjusz Kamicjusz changed the title expand default config and PlaceholderAPI support in internal placeholders GH-125 expand default config and PlaceholderAPI support in internal placeholders May 24, 2024
Copy link
Member

@CitralFlo CitralFlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor lang error

Copy link
Member

@vLuckyyy vLuckyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are very good, I also like your cooperation. Keep it up guys!

Copy link
Member

@Jakubk15 Jakubk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@vLuckyyy vLuckyyy merged commit 39cfdc9 into master Jun 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants