Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-162 Add DatabaseManager closure on shutdown, add scheduler adapter. #162

Merged
merged 6 commits into from
Sep 5, 2024
Merged

GH-162 Add DatabaseManager closure on shutdown, add scheduler adapter. #162

merged 6 commits into from
Sep 5, 2024

Conversation

vLuckyyy
Copy link
Member

No description provided.

@vLuckyyy vLuckyyy changed the title Add DatabaseManager closure on shutdown GH-162 Add DatabaseManager closure on shutdown Aug 18, 2024
@vLuckyyy vLuckyyy changed the title GH-162 Add DatabaseManager closure on shutdown GH-162 Add DatabaseManager closure on shutdown, add scheduler adapter. Aug 18, 2024
Rollczi
Rollczi reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@Rollczi Rollczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread.currentThread().isInterrupted() czemu jest to callowane?

Jakubk15
Jakubk15 reviewed Aug 23, 2024
View reviewed changes
src/main/java/com/eternalcode/discordapp/scheduler/VirtualThreadSchedulerImpl.java

public class VirtualThreadSchedulerImpl implements Scheduler {

// works on javca 21+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// works on javca 21+
// works on javac 21+

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java

@vLuckyyy vLuckyyy merged commit 1c2aa8e into master Sep 5, 2024
3 checks passed
@vLuckyyy vLuckyyy deleted the close-database-connection branch September 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rollczi Rollczi Rollczi left review comments

@Hyd3r1 Hyd3r1 Hyd3r1 approved these changes

@Jakubk15 Jakubk15 Jakubk15 approved these changes

@P1otrulla P1otrulla P1otrulla approved these changes

@eripe14 eripe14 eripe14 approved these changes

@imDMK imDMK imDMK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vLuckyyy @Rollczi @Hyd3r1 @Jakubk15 @P1otrulla @eripe14 @imDMK