GH-107 Multification setup #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be tested in the future, waiting for bossbar merge in Multification |
Rollczi
reviewed
Oct 22, 2024
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTagCommand.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/logout/LogoutController.java
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Rollczi
approved these changes
Oct 22, 2024
vLuckyyy
approved these changes
Oct 25, 2024
P1otrulla
approved these changes
Oct 26, 2024
|
|
||
| @Command(name = "combatlog", aliases = "combat") | ||
| @Permission("eternalcombat.reload") | ||
| public class EternalCombatReloadCommand { | ||
|
|
||
| private static final String RELOAD_MESSAGE = "<b><gradient:#8a1212:#fc6b03>EternalCombat:</gradient></b> Reloaded EternalCombat in <color:#fce303>{TIME}ms!</color>"; | ||
| private static final Notice RELOAD_MESSAGE = BukkitNotice.builder() |
There was a problem hiding this comment.
w tym przypadku może być proste Notice -> BukkitNotice różni się tym że posiada dodatkowo metody stricte pod dzwieki bukkitowe
|
|
||
| @Permission("eternalcombat.tagout") |
There was a problem hiding this comment.
following simple rule: leave code better than was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #107
This pull request includes several changes to integrate the Multification library into the EternalCombat plugin, refactor notification handling, and remove unused code. The most important changes include adding Multification dependencies, updating the notification system, and removing the
FightBossBarServiceclass.Multification Integration:
buildSrc/src/main/kotlin/Versions.kt: AddedMULTIFICATIONconstant.eternalcombat-plugin/build.gradle.kts: Added Multification dependencies and updatedshadowJarconfiguration. [1] [2]Notification System Refactor:
eternalcombat-plugin/src/main/java/com/eternalcode/combat/EternalCombatReloadCommand.java: ReplacedFormatterwith MultificationNoticefor reload messages. [1] [2] [3]eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/PluginConfig.java: Updated notification messages to use MultificationNotice. [1] [2]Code Cleanup:
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java: RemovedFightBossBarServiceand updated related code. [1] [2] [3] [4]eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTagCommand.java: Refactored to use MultificationNoticefor combat status and tag messages. [1] [2] [3]