Skip to content

Conversation

@Jakubk15
Copy link
Member

@Jakubk15 Jakubk15 commented Oct 4, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the plugin's update checking mechanism. It migrates the existing custom update logic, which previously relied on GitCheck, into the shared eternalcode-commons library. This change introduces a standardized and more robust update checker based on Modrinth, complete with caching, leading to a more efficient and maintainable system for notifying users about new plugin versions.

Highlights

  • Dependency Migration: The GitCheck library has been removed and replaced with the eternalcode-commons-updater module, centralizing update logic.
  • Updater Service Refactor: The UpdaterService has been completely rewritten to utilize ModrinthUpdateChecker for update checks and Caffeine for caching results, improving efficiency and reliability.
  • Notification Logic Update: The UpdaterNotificationController now integrates with the new UpdaterService API, simplifying the update notification process for players.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Jakubk15 Jakubk15 linked an issue Oct 4, 2025 that may be closed by this pull request
@Jakubk15 Jakubk15 changed the title Move updater to eternalcode-commons library GH-278 Move updater to eternalcode-commons library Oct 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully refactors the plugin's updater functionality to use the shared eternalcode-commons library. The new implementation is cleaner and more robust, leveraging caching and modern asynchronous patterns. I have one suggestion to improve maintainability by avoiding a hardcoded permission string. Overall, this is a great improvement.

Copy link
Member

@P1otrulla P1otrulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 😎

@vLuckyyy vLuckyyy merged commit 337eb7d into master Oct 6, 2025
1 check passed
@vLuckyyy vLuckyyy deleted the move-updater-to-commons branch October 6, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move updater to EternalCodeCommons.

6 participants