GH-285 Remove border when player is not in combat

[CitralFlo]

Add plugins to runServer for easier tests. Fixes: GH-285

[gemini-code-assist]

Summary of Changes

Hello @CitralFlo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on two main areas: enhancing the development and testing workflow by configuring the runServer task with specific Minecraft versions and necessary plugins, and improving the combat system's user experience by ensuring that visual borders are promptly removed once a player exits combat. These changes aim to make testing more efficient and the combat mechanics more accurate.

Highlights

• Test Environment Setup: The runServer task in build.gradle.kts has been updated to use Minecraft version 1.21.8 and now automatically downloads essential plugins (WorldEdit, PacketEvents, WorldGuard) to streamline the testing process.
• Combat Border Logic Refinement: A change in BorderTriggerController.java ensures that a player's combat border is explicitly cleared when they are no longer in combat, specifically during a PlayerMoveEvent, addressing the issue of lingering borders.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where the combat border was not being removed for players who are not in combat. It also adds several plugins to the runServer task to facilitate testing. My review focuses on a performance optimization in the border clearing logic and a maintainability improvement in the build script.

[Jakubk15]

Is gemini's comment valid? If so, please adjust to the suggestion and check if the border exists prior to clearing it.

[P1otrulla]

follow AI commet for optimization

[CitralFlo]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a delay when clearing the combat border after a fight ends, which appears to be a fix for a timing-related issue. Additionally, it configures the runServer task to download necessary plugins for easier testing. My review includes suggestions to improve maintainability by replacing a magic number with a constant and managing dependency URLs in the build script more effectively.