GH-915 Fix death message handling, add {CAUSE} placeholder and update PL/EN configurations

[vLuckyyy]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@vLuckyyy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 351434b and b9fdea0.

📒 Files selected for processing (1)

• eternalcore-core/src/main/java/com/eternalcode/core/feature/deathmessage/DeathMessageController.java (2 hunks)

Walkthrough

The changes update how death messages are processed and documented across multiple components. In the DeathMessageController, the logic now retrieves the player's last damage cause. When the damage is linked to an entity event, it identifies the killer and sends a corresponding message. If there is a distinct damage cause, a tailored message is delivered; otherwise, a default unknown cause message is used. Additionally, the translation classes in English and Polish have been revised. The updates expand the descriptions of the death messages, clarifying parameters such as {PLAYER}, {KILLER}, and {CAUSE}. A typographical error in the Polish translation has been corrected, and overall documentation details have been enhanced for clarity without altering the underlying functionality.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

eternalcore-core/src/main/java/com/eternalcode/core/feature/deathmessage/DeathMessageController.java (1)

52-61: Consider extracting notice creation to a helper method.

The notice creation logic is repeated in multiple places. A helper method would reduce code duplication.

+    private void sendDeathNotice(Player player, String cause) {
+        this.noticeService.create()
+            .noticeOptional(translation -> RandomElementUtil.randomElement(translation.event().unknownDeathCause()))
+            .placeholder("{PLAYER}", player.getName())
+            .placeholder("{CAUSE}", cause)
+            .onlinePlayers()
+            .send();
+    }

eternalcore-core/src/main/java/com/eternalcode/core/translation/implementation/ENTranslation.java (1)

299-307: Consider adding more common death causes.

The death cause mapping only covers VOID and FALL. Consider adding other common causes like FIRE, DROWNING, etc.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34aa32c and 915c371.

📒 Files selected for processing (3)

• eternalcore-core/src/main/java/com/eternalcode/core/feature/deathmessage/DeathMessageController.java (2 hunks)
• eternalcore-core/src/main/java/com/eternalcode/core/translation/implementation/ENTranslation.java (1 hunks)
• eternalcore-core/src/main/java/com/eternalcode/core/translation/implementation/PLTranslation.java (1 hunks)

🔇 Additional comments (4)

eternalcore-core/src/main/java/com/eternalcode/core/feature/deathmessage/DeathMessageController.java (2)

37-50: LGTM! Good separation of PvP death handling.

The code properly identifies and handles player vs player deaths by checking the damage cause and damager entity.

---

63-71: LGTM! Good fallback for unknown death causes.

The code properly handles cases where the death cause cannot be determined.

eternalcore-core/src/main/java/com/eternalcode/core/translation/implementation/ENTranslation.java (1)

284-291: LGTM! Clear documentation of placeholders.

The descriptions clearly explain when each placeholder is used.

eternalcore-core/src/main/java/com/eternalcode/core/translation/implementation/PLTranslation.java (1)

289-296: LGTM! Fixed typo in Polish translation.

The typo in "ciężkiej" has been corrected and placeholder documentation matches English version.