GH-919 Fix sudo placeholder's

[vLuckyyy]

No description provided.

[coderabbitai]

Walkthrough

The changes update how sudo commands report their execution target. In the SudoCommand class, the sendSudoSpy method now accepts an additional parameter to identify the command sender (either player or console). As a result, calls within the console and player methods are modified to pass the appropriate sender. Corresponding updates in the messaging classes (ENSudoMessages and PLSudoMessages) adjust the command notification messages. These updates introduce the {TARGET} placeholder to clearly indicate the execution context in the notifications. Method signatures, field annotations, and message content have been revised consistently to include the new target information.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/messages/PLSudoMessages.java (1)

16-17: Consider matching the message style

The messages use different styles for the same information:

• Spy message: "wykonał komendę: {COMMAND} na: {TARGET}"
• User message: "Wykonałeś komendę: {COMMAND} na: {TARGET}"

It might be clearer to keep the same order and style in both messages.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17e9e0c and 32008eb.

📒 Files selected for processing (3)

• eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/SudoCommand.java (3 hunks)
• eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/messages/ENSudoMessages.java (1 hunks)
• eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/messages/PLSudoMessages.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build (17)

🔇 Additional comments (7)

eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/messages/ENSudoMessages.java (2)

13-14: Nice addition of the target information!

The message now clearly shows who ran the command and where it was executed.

---

16-17: Good consistency in message updates!

The message format matches the spy message style, making it easy to understand where commands are executed.

eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/messages/PLSudoMessages.java (1)

13-14: Nice work on the clear message format!

The spy message now clearly shows who ran the command and on which target. The description explains all placeholders well.

eternalcore-core/src/main/java/com/eternalcode/core/feature/sudo/SudoCommand.java (4)

15-15: Nice addition!

The CommandSender import is just what we needed for the improved sudo tracking.

---

36-36: Looking good!

The console method now properly shows who's running the command.

---

44-44: Perfect update!

The player method now clearly shows which player is running the command.

---

47-47: Great improvements to command tracking!

The new target parameter and placeholders make it super clear who's running what command.

Also applies to: 52-52, 62-62