feat: add a feature toggle for rsa
#550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rsa` crate has an [open CVE](https://www.cvedetails.com/cve/CVE-2023-49092/). which seems [non-trivial to fix](RustCrypto/RSA#19). There has been some recent progress, but it's still unclear if it will actually fix the issue. I'm actively working on getting native SSH support in gitoxide [here](GitoxideLabs/gitoxide#2081) and this particular CVE may become an issue for that integration. This commit adds a feature toggle to enable/disable the `rsa` dependency. This also fixes a race condition in the `test_agent` test.
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rsacrate has an open CVE. which seems non-trivial to fix. There has been some recent progress, but it's still unclear if it will actually fix the issue.I'm actively working on getting native SSH support in gitoxide here and this particular CVE may become an issue for that integration.
This commit adds a feature toggle to enable/disable the
rsadependency.This also fixes a race condition in the
test_agenttest.