feat(table): add base tooltip for error and image cells#210
Merged
Conversation
CammilleCC
commented
Jun 29, 2026
| import { assertNever } from '../../../utils/helpers' | ||
|
|
||
| import { type VariableError } from '../../../types' | ||
| const DELAY = { open: 250, switch: 80, close: 400 } |
Member
Author
There was a problem hiding this comment.
@tmichela Please feel free to play around on the values here to see what's best for both use case.
Closed
tmichela
reviewed
Jun 30, 2026
Member
Author
|
I'll merge this now. Thanks for having a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #208: This swaps the previous error tooltip for a shared
TableTooltipthat works for both error and image cells.Image previews needed almost the same hover, positioning, delay, and dismiss behavior as error cells, so instead of building another near-duplicate tooltip, this puts that logic in one place. A small
CellTooltipunion (error | image) handles the bits that differ: what gets rendered and how each tooltip is compared.The main benefit is that the tooltip behavior stays consistent. Error cells should behave the same as before, image cells get the same polish, and adding another tooltip type later should be a small change instead of another component.
chrome_D8S8YOQmEk.mp4