Count a variable as skipped if its dependencies are skipped#561
Open
takluyver wants to merge 1 commit into
Open
Count a variable as skipped if its dependencies are skipped#561takluyver wants to merge 1 commit into
takluyver wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 79.34% 79.32% -0.02%
==========================================
Files 42 42
Lines 7659 7658 -1
==========================================
- Hits 6077 6075 -2
- Misses 1582 1583 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmichela
reviewed
Apr 27, 2026
Comment on lines
+518
to
519
| if dep_errors and not all(isinstance(e, Skip) for _, e in dep_errors): | ||
| errors[name] = DependencyError(dep_errors) |
Member
There was a problem hiding this comment.
Suggested change
| if dep_errors and not all(isinstance(e, Skip) for _, e in dep_errors): | |
| errors[name] = DependencyError(dep_errors) | |
| if dep_errors: | |
| errors[name] = DependencyError(dep_errors) | |
| if all(isinstance(e, Skip) for _, e in dep_errors): | |
| errors[name] = Skip(str(errors[name])) |
I suggest to keep building the dependency tree of skipped variables, to help understand why it was skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, a dependent variable is recorded as skipped if its dependencies return None, but as having an error if its dependencies raise
Skip:With this change, the
Skipis propagated instead, making it easier to see which variables actually hit an error: