Set module coords to 0 for jungfrau detector of one module.#206
Set module coords to 0 for jungfrau detector of one module.#206kakhahmed wants to merge 1 commit into
module coords to 0 for jungfrau detector of one module.#206Conversation
|
I'm not sure this is quite right: if they called the solo module '1', would the 2 modules of JF1M be '2' and '3'? We should check if any other instruments have done strange bits of numbering like this - if not, maybe the best thing is to special-case it in the EXtra-data component for the name |
Yes. So the same detector-type modules have an incrementing module number. For example, we can have the same issue with AGIPD if there is another added AGIPD at MID or SPB. The module numbers will start from 16,... But what is the assumption this code is based on? That we can have two Jungfraus in the same instrument using JNFR01? Adding a special case should work I guess, But I don't think it's a long-term solution, unfortunately. |
This MR fixes an issue when plotting xarray for FXE_XAD_JF500K which has one module
JNGFR03.This fix is used by https://git.xfel.eu/calibration/pycalibration/-/merge_requests/775
EDITED:
More info as the description was too short.
This issue happens after creating components.JUNGFRAU object for
FXE_XAD_JF500Kto form a DataArray fordata.adcand the plot it usingplot_data_fast. The problem is that the module coordinates for this DataArray are of a value3. As the data channel has JNGFR03.