Update geometry metadata for masks#297
Open
turkot wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CrystFEL geometry files mask information can be provided as (old style):
mask_file = <file_name>
mask = <hdf5_path>
mask_good = 0x0
mask_bad = 0xffff
or (new style, from CrystFEL v0.10.0):
mask{N}_file = <file_name>
mask{N}_data = <hdf5_path>
mask{N}_goodbits = 0x0
mask{N}_badbits = 0xffff
with {N} in an inclusive range [0, 7].
This MR implements reading and storing of mask information in both styles. It will not work with the current version of cfelpyutils, but the required update to that package is also under way.