Add source names to DetectorData#479
Merged
Merged
Conversation
philsmt
added
the
skip-changelog
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 73.14% 73.41% +0.27%
==========================================
Files 35 35
Lines 6248 6304 +56
==========================================
+ Hits 4570 4628 +58
+ Misses 1678 1676 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
takluyver
reviewed
Apr 16, 2026
takluyver
reviewed
Apr 16, 2026
takluyver
reviewed
Apr 16, 2026
philsmt
force-pushed
the
feat/detdata-source-names
branch
from
fbd029c to
d1516db
Compare
takluyver
reviewed
Apr 16, 2026
Member
|
LGTM |
philsmt
force-pushed
the
feat/detdata-source-names
branch
from
c471711 to
d1516db
Compare
Collaborator
Author
|
Hmmm, I had not yet seen your LGTM and thought I had forgot to push. It weirded me out now to see I had, but yet still the push was successful. Didn't see your test fix there! Thanks for review! |
philsmt
force-pushed
the
feat/detdata-source-names
branch
from
d1516db to
100a485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for source names to new
DetectorDataAPI based on the work already done in #146Given we just merged the API yesterday, I'll omit a changelog entry unless this lingers for a long time.