Skip to content

Add split_trains() method to more component classes#508

Open
takluyver wants to merge 5 commits into
masterfrom
feat/more-split-trains
Open

Add split_trains() method to more component classes#508
takluyver wants to merge 5 commits into
masterfrom
feat/more-split-trains

Conversation

@takluyver

Copy link
Copy Markdown
Member

This adds select_trains() to Timepix3 and XGM, and split_trains() to those plus DelayLineDetector and the pulse pattern components.

While running the tests on this, I discovered that generating the DLD mock data for tests was very slow, due to the way h5py does broadcasting, so the first commit is a workaround for that.

@takluyver takluyver requested a review from philsmt June 9, 2026 09:02
@takluyver takluyver added the enhancement New feature or request label Jun 9, 2026
@takluyver takluyver force-pushed the feat/more-split-trains branch from 406dc1a to 2d4b635 Compare June 9, 2026 09:12
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.17%. Comparing base (327b117) to head (2d4b635).

Files with missing lines Patch % Lines
src/extra/components/pulses.py 66.66% 3 Missing ⚠️
src/extra/components/timepix.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   73.90%   74.17%   +0.26%     
==========================================
  Files          35       35              
  Lines        6909     6969      +60     
==========================================
+ Hits         5106     5169      +63     
+ Misses       1803     1800       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@takluyver

Copy link
Copy Markdown
Member Author

I've added basic tests, but it's not much more than a smoketest, I don't check accessing any data from the split parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant