Add split_trains() method to more component classes#508
Open
takluyver wants to merge 5 commits into
Open
Conversation
406dc1a to
2d4b635
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 73.90% 74.17% +0.26%
==========================================
Files 35 35
Lines 6909 6969 +60
==========================================
+ Hits 5106 5169 +63
+ Misses 1803 1800 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I've added basic tests, but it's not much more than a smoketest, I don't check accessing any data from the split parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds select_trains() to
Timepix3andXGM, and split_trains() to those plusDelayLineDetectorand the pulse pattern components.While running the tests on this, I discovered that generating the DLD mock data for tests was very slow, due to the way h5py does broadcasting, so the first commit is a workaround for that.