TOFAnalogResponse: use thresholding to obtain a background-free response function#511
Open
daniloefl wants to merge 9 commits into
Open
TOFAnalogResponse: use thresholding to obtain a background-free response function#511daniloefl wants to merge 9 commits into
daniloefl wants to merge 9 commits into
Conversation
daniloefl
force-pushed
the
enhancement/improve_analog_from_counting
branch
from
eb0514f to
e70dd32
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 73.72% 73.86% +0.14%
==========================================
Files 35 35
Lines 6927 6961 +34
==========================================
+ Hits 5107 5142 +35
+ Misses 1820 1819 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniloefl
changed the title
* Apply grating mask * Removed background subtraction: done in the Gotthard calibration. * Updated tests. --------- Co-authored-by: Danilo Ferreira de Lima <danilo.enoque.ferreira.de.lima@xfel.de> Co-authored-by: Thomas Michelat <32831491+tmichela@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOFAnalogResponse aligns data from different conditions and averages them to extract the response function of a time-of-flight spectrometer. It can also simply count photo-electrons to obtain the detector response effect, ignoring the spectrometer impact. The latter mode is not very useful, as it disregards part of the response.
In this PR, the method of counting photo-electrons is used to threshold the data, while the analog data collected is still averaged out for the data passing the threshold. This allows this application to operate in very high-noise regimes.