Skip to content

CookieboxCalibration: Normalize transmission by pulse energy and detect RoI robustly#512

Open
daniloefl wants to merge 8 commits into
masterfrom
enhancement/normalize_transmission
Open

CookieboxCalibration: Normalize transmission by pulse energy and detect RoI robustly#512
daniloefl wants to merge 8 commits into
masterfrom
enhancement/normalize_transmission

Conversation

@daniloefl

Copy link
Copy Markdown
Contributor

This PR contains two elements:

  1. The transmission calculation is affected currently due to variations in the pulse energy during the data collection. This is corrected here by normalizing not only by the angular dependence given by the FEL polarization, but also by the pulse energy within the data collected (which is now also calculated and stored for this purpose).
  2. The region of interest containing the photoline can be given or auto-detected if it can be assumed the only other peak comes from the Auger-Meitner. In this PR, the autodetection is slightly improved by smoothing the signal beforehand.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.19%. Comparing base (c727444) to head (535d624).

Files with missing lines Patch % Lines
src/extra/applications/cookiebox.py 86.36% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   73.72%   74.19%   +0.47%     
==========================================
  Files          35       35              
  Lines        6927     6926       -1     
==========================================
+ Hits         5107     5139      +32     
+ Misses       1820     1787      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daniloefl daniloefl force-pushed the enhancement/normalize_transmission branch from b1c68a6 to 553e8b9 Compare July 1, 2026 19:58
@daniloefl daniloefl changed the title Draft: CookieboxCalibration: Normalize transmission by pulse energy and detect RoI robustly CookieboxCalibration: Normalize transmission by pulse energy and detect RoI robustly Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant