ViewPager with pageMargin over-scroll not work when scrolling forward and backward #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Page margin option in ViewPager demo
…om event Lower delta to avoid missing bugs
tamhuynhit
force-pushed
the
fix-overscroll-disable-in-padding-viewpager
branch
from
8844234 to
80ad0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I face the same issue as the one mentioned in #35 and #23
The Over scroll effect does not work properly when I use a
ViewPagerwithsetPageMarginto a non-zero value. I found out the problem comes from theViewPagerbecause it doesn't give us the correctpositionOffsetinonPageScrolled. The offset is very small nearly to 0 but not 0, the same for 1.So a way to fix this is to compare the float
mLastPagerScrollOffsetapproximately and it worksPlease test this and let me know if there is any issue