Skip to content

fix: when you set jpegThumbnail, image not appear on app mobile #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

Faelst
Copy link

@Faelst Faelst commented Apr 29, 2025

πŸ“¦ Pull Request β€” Fix video thumbnail handling on mobile apps

Context

Currently, when sending videos through the API, setting the jpegThumbnail manually (e.g., using a local image file like video-cover.png) was not showing any thumbnail preview on mobile WhatsApp applications.

After investigating, it was observed that:

  • WhatsApp expects a correctly sized, compressed, and proper JPEG format thumbnail.
  • Simply attaching any PNG-converted image as jpegThumbnail without proper optimization causes the thumbnail to be ignored silently on mobile devices.

What has changed

  • Removed setting jpegThumbnail manually from static images.
  • Set gifPlayback = false for all video media messages (keeping consistent behavior between web and mobile apps).

Now, the native behavior of WhatsApp handles thumbnails better when jpegThumbnail is not manually set incorrectly.


How it was fixed

if (mediaMessage.mediatype === 'video') {
  prepareMedia[mediaType].gifPlayback = false;
}

No longer trying to inject a static jpegThumbnail.


Impact

  • Fixes videos sent through the API not showing thumbnails on mobile apps.
  • Makes API behavior more aligned with WhatsApp mobile/web expectations.
  • Reduces chance of future media handling bugs related to thumbnail encoding.

Related

  • Commit: fix: when you set jpegThumbnail, image not appear on app mobile

βœ… Now videos sent through the API show the proper behavior on both WhatsApp Web and WhatsApp Mobile.

Summary by Sourcery

Fix video thumbnail handling for WhatsApp media messages to ensure proper thumbnail display on mobile apps

New Features:

  • Ensured consistent video thumbnail behavior across WhatsApp Web and Mobile platforms

Bug Fixes:

  • Resolved issue with video thumbnails not appearing on mobile WhatsApp applications
  • Removed manual thumbnail injection that was causing thumbnail preview failures

Enhancements:

  • Improved media message handling to align with WhatsApp mobile and web expectations
  • Simplified thumbnail processing for video messages

Copy link

sourcery-ai bot commented Apr 29, 2025

Reviewer's Guide

This pull request fixes missing video thumbnails on mobile apps by removing the code that manually set the jpegThumbnail property from a static image file, allowing the platform's native thumbnail generation to function correctly.

File-Level Changes

Change Details Files
Removed manual video thumbnail setting
  • Deleted code assigning a static image file to the jpegThumbnail property for video messages.
  • Ensured gifPlayback remains false for videos (no code change, but relevant context).
src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts

Possibly linked issues

  • #0: PR removes incorrect manual jpegThumbnail setting fixing issue of missing video thumbnails on mobile when auto-download is disabled.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Faelst - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

@Faelst
Copy link
Author

Faelst commented Apr 29, 2025

Issue related: #1385

neocol83 added a commit to neocol83/evolution-api that referenced this pull request Apr 29, 2025
@DavidsonGomes DavidsonGomes merged commit e6a72bd into EvolutionAPI:develop May 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants