fix distributed evaluation on empty task shards#1233
Merged
Luodian merged 2 commits intoEvolvingLMMs-Lab:mainfrom Mar 7, 2026
Merged
fix distributed evaluation on empty task shards#1233Luodian merged 2 commits intoEvolvingLMMs-Lab:mainfrom
Luodian merged 2 commits intoEvolvingLMMs-Lab:mainfrom
Conversation
Inject a padding request when a rank receives zero docs and align request/filter synchronization across ranks so TP+DP jobs with limit<=world_size no longer crash or hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In scope
lmms_eval/api/task.pyto preserve distributed synchronization for empty shards.lmms_eval/evaluator.pyto keep request/filter coordination consistent across ranks.Out of scope
Validation
uv run --with pytest python -m pytest test/eval/test_construct_requests.py -q| sample size:N=23 tests| key metrics:23 passed| result:passuv run python - <<'PY' import lmms_eval.evaluator as evaluator print(hasattr(evaluator, 'evaluate')) PY| sample size:N=1 smoke check| key metrics:evaluate=True| result:passuv run pre-commit run --all-files| sample size:N=all tracked files| key metrics:black, isort passed| result:passRisk / Compatibility
Type of Change