Skip to content

Fix missing VideoReader imports in FALCONBench and LongVideoBench#1258

Merged
Luodian merged 1 commit intoEvolvingLMMs-Lab:mainfrom
akawincent:pr
Mar 26, 2026
Merged

Fix missing VideoReader imports in FALCONBench and LongVideoBench#1258
Luodian merged 1 commit intoEvolvingLMMs-Lab:mainfrom
akawincent:pr

Conversation

@akawincent
Copy link
Copy Markdown
Contributor

@akawincent akawincent commented Mar 19, 2026

Summary

This PR fixes missing VideoReader imports in two task utilities that call VideoReader(...) during video loading:

  • lmms_eval/tasks/FALCONBench/utils.py
  • lmms_eval/tasks/longvideobench/utils.py

Both files used VideoReader(...) but only imported cpu from decord. This can raise a NameError when the corresponding code path is executed.

Changes

  • add VideoReader to the decord import in FALCONBench
  • add VideoReader to the decord import in LongVideoBench

Notes

  • this is a minimal fix with no intended behavioral change beyond preventing the missing-import error
  • no task logic or sampling behavior was modified

@akawincent akawincent changed the title Fix missing VideoReader imports in FALCONBench and LongVideoBench Fix missing video_metadata argument in qwen2.5-vl processor forward path Mar 20, 2026
@akawincent akawincent changed the title Fix missing video_metadata argument in qwen2.5-vl processor forward path Fix missing VideoReader imports in FALCONBench and LongVideoBench Mar 20, 2026
@akawincent
Copy link
Copy Markdown
Contributor Author

Hi @Luodian @kcz358 !

This PR fixes an import missing issue, and the code changes are minor.
Would you be willing to do a quick review?
Thanks~

Copy link
Copy Markdown
Contributor

@Luodian Luodian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward import fix. Both files use VideoReader() but only imported cpu from decord.

@Luodian Luodian merged commit fdb5bfa into EvolvingLMMs-Lab:main Mar 26, 2026
5 checks passed
@akawincent akawincent deleted the pr branch March 27, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants