Fix missing VideoReader imports in FALCONBench and LongVideoBench#1258
Merged
Luodian merged 1 commit intoEvolvingLMMs-Lab:mainfrom Mar 26, 2026
Merged
Fix missing VideoReader imports in FALCONBench and LongVideoBench#1258Luodian merged 1 commit intoEvolvingLMMs-Lab:mainfrom
Luodian merged 1 commit intoEvolvingLMMs-Lab:mainfrom
Conversation
Contributor
Author
Luodian
approved these changes
Mar 26, 2026
Contributor
Luodian
left a comment
There was a problem hiding this comment.
LGTM — straightforward import fix. Both files use VideoReader() but only imported cpu from decord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes missing
VideoReaderimports in two task utilities that callVideoReader(...)during video loading:lmms_eval/tasks/FALCONBench/utils.pylmms_eval/tasks/longvideobench/utils.pyBoth files used
VideoReader(...)but only importedcpufromdecord. This can raise aNameErrorwhen the corresponding code path is executed.Changes
VideoReaderto thedecordimport inFALCONBenchVideoReaderto thedecordimport inLongVideoBenchNotes