Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): roll back flake8 version to v6 #322

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

OmarAlJarrah
Copy link
Contributor

@OmarAlJarrah OmarAlJarrah commented Feb 6, 2024

  • Code is up-to-date with the main branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.

Description

The version of datamodel-code-generator used by the fastapi-code-generator uses version 6.X.X of flake8. Obviously flake8 version 7.X.X comes with a breaking change that breaks our SDK generator. As a conclusion, we are forced to stick with version 6.X.X of flake8 for the time being.

@OmarAlJarrah OmarAlJarrah requested a review from a team as a code owner February 6, 2024 14:44
@OmarAlJarrah OmarAlJarrah changed the title revert(deps-dev): roll back flake8 version to v6 chore(deps-dev): roll back flake8 version to v6 Feb 6, 2024
Copy link
Member

@mohnoor94 mohnoor94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@OmarAlJarrah
Copy link
Contributor Author

OmarAlJarrah commented Feb 6, 2024

@mohnoor94

Why?

The version of datamodel-code-generator used by the fastapi-code-generator uses version 6.X.X of flake8. Obviously flake8 version 7.X.X comes with a breaking change that breaks our SDK generator. As a conclusion, we are forced to stick with version 6.X.X of flake8 for the time being.

@osama-salman99 osama-salman99 merged commit f2aa27b into main Feb 7, 2024
5 checks passed
@osama-salman99 osama-salman99 deleted the OmarAlJarrah/revert-flake8-to-v6 branch February 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants