Adding python classes for new Feature View type SortedFeatureView

ExpediaGroup · Feb 14, 2025 · 5671bad · 5671bad
1 parent 76c29da
commit 5671bad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/sdk/python/feast/sort_key.py b/sdk/python/feast/sort_key.py
@@ -33,15 +33,15 @@ class SortKey:
 
     name: str
     value_type: ValueType
-    default_sort_order: int
+    default_sort_order: SortOrder.Enum.ValueType
     tags: Dict[str, str]
     description: str
 
     def __init__(
         self,
         name: str,
         value_type: ValueType,
-        default_sort_order: int = int(SortOrder.Enum.ASC),
+        default_sort_order: SortOrder.Enum.ValueType = SortOrder.ASC,
         tags: Optional[Dict[str, str]] = None,
         description: str = "",
     ):
@@ -79,7 +79,7 @@ def from_proto(cls, proto: SortKeyProto) -> "SortKey":
         return cls(
             name=proto.name,
             value_type=ValueType(proto.value_type),
-            default_sort_order=int(proto.default_sort_order),
+            default_sort_order=proto.default_sort_order,
             tags=dict(proto.tags),
             description=proto.description,
-        )
+        )
diff --git a/sdk/python/feast/sorted_feature_view.py b/sdk/python/feast/sorted_feature_view.py
@@ -213,4 +213,4 @@ def from_proto(cls, sfv_proto):
                 )
             )
 
-        return sorted_feature_view
+        return sorted_feature_view
-Original file line number
+Diff line change
@@ Expand Up / @@ -213,4 +213,4 @@ def from_proto(cls, sfv_proto): @@
                     )
                 )
-            return sorted_feature_view
+            return sorted_feature_view