Skip to content

Commit

Permalink
fix: address Bhargav's comments 2
Browse files Browse the repository at this point in the history
  • Loading branch information
zabarn committed Oct 21, 2024
1 parent 50d3c48 commit 84e268c
Showing 1 changed file with 0 additions and 34 deletions.
34 changes: 0 additions & 34 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -1257,23 +1257,6 @@ def materialize_incremental(
feature_views
)

if (
getattr(self.config.online_store, "lazy_table_creation", False)
and self.config.provider == "expedia"
):
# feature_views_to_delete = self._get_feature_views_to_delete()
# don't delete any tables for now

self._get_provider().update_infra(
project=self.project,
tables_to_delete=[],
tables_to_keep=feature_views_to_materialize,
entities_to_delete=[],
entities_to_keep=[],
partial=True,
materialization_update=True, # type: ignore
)

_print_materialization_log(
None,
end_date,
Expand Down Expand Up @@ -1370,23 +1353,6 @@ def materialize(
feature_views
)

if (
getattr(self.config.online_store, "lazy_table_creation", False)
and self.config.provider == "expedia"
):
# feature_views_to_delete = self._get_feature_views_to_delete()
# don't delete any tables for now

self._get_provider().update_infra(
project=self.project,
tables_to_delete=[],
tables_to_keep=feature_views_to_materialize,
entities_to_delete=[],
entities_to_keep=[],
partial=True,
materialization_update=True, # type: ignore
)

_print_materialization_log(
start_date,
end_date,
Expand Down

0 comments on commit 84e268c

Please sign in to comment.