fixing failing tests

ExpediaGroup · Feb 24, 2025 · ad8ddab · ad8ddab
1 parent 11ace08
commit ad8ddab
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -738,6 +738,7 @@ def plan(
             ...     feature_views=[driver_hourly_stats_view],
             ...     on_demand_feature_views=list(),
             ...     stream_feature_views=list(),
+            ...     sorted_feature_views=list(),
             ...     entities=[driver],
             ...     feature_services=list(),
             ...     permissions=list())) # register entity and feature view
@@ -2134,4 +2135,4 @@ def _validate_data_sources(data_sources: List[DataSource]):
         if case_insensitive_ds_name in ds_names:
             raise DataSourceRepeatNamesException(case_insensitive_ds_name)
         else:
-            ds_names.add(case_insensitive_ds_name)
+            ds_names.add(case_insensitive_ds_name)
diff --git a/sdk/python/feast/infra/registry/registry.py b/sdk/python/feast/infra/registry/registry.py
@@ -80,6 +80,7 @@ class FeastObjectType(Enum):
     FEATURE_VIEW = "feature view"
     ON_DEMAND_FEATURE_VIEW = "on demand feature view"
     STREAM_FEATURE_VIEW = "stream feature view"
+    SORTED_FEATURE_VIEW = "sorted feature view"
     FEATURE_SERVICE = "feature service"
     PERMISSION = "permission"
 
@@ -99,6 +100,9 @@ def get_objects_from_registry(
             FeastObjectType.ON_DEMAND_FEATURE_VIEW: registry.list_on_demand_feature_views(
                 project=project
             ),
+            FeastObjectType.SORTED_FEATURE_VIEW: registry.list_sorted_feature_views(
+                project=project
+            ),
             FeastObjectType.STREAM_FEATURE_VIEW: registry.list_stream_feature_views(
                 project=project,
             ),
@@ -117,6 +121,7 @@ def get_objects_from_repo_contents(
             FeastObjectType.DATA_SOURCE: repo_contents.data_sources,
             FeastObjectType.ENTITY: repo_contents.entities,
             FeastObjectType.FEATURE_VIEW: repo_contents.feature_views,
+            FeastObjectType.SORTED_FEATURE_VIEW: repo_contents.sorted_feature_views,
             FeastObjectType.ON_DEMAND_FEATURE_VIEW: repo_contents.on_demand_feature_views,
             FeastObjectType.STREAM_FEATURE_VIEW: repo_contents.stream_feature_views,
             FeastObjectType.FEATURE_SERVICE: repo_contents.feature_services,
@@ -1108,6 +1113,10 @@ def delete_project(
                 for stream_feature_view in list_stream_feature_views:
                     self.delete_feature_view(stream_feature_view.name, name)
 
+                list_sorted_feature_views = self.list_sorted_feature_views(name)
+                for sorted_feature_view in list_sorted_feature_views:
+                    self.delete_feature_view(sorted_feature_view.name, name)
+
                 list_feature_views = self.list_feature_views(name)
                 for feature_view in list_feature_views:
                     self.delete_feature_view(feature_view.name, name)
@@ -1126,4 +1135,4 @@ def delete_project(
                 if commit:
                     self.commit()
                 return
-        raise ProjectNotFoundException(name)
+        raise ProjectNotFoundException(name)