Skip to content

Commit

Permalink
fix: Update milvus online store to eg-milvus to differeniate from the…
Browse files Browse the repository at this point in the history
… opensource implementation
  • Loading branch information
piket committed Oct 29, 2024
1 parent 498ccea commit d7db708
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions sdk/python/tests/expediagroup/eg_milvus_online_store_creator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Dict

from testcontainers.core.container import DockerContainer
from testcontainers.milvus import MilvusContainer
from testcontainers.core.waiting_utils import wait_for_logs

from tests.integration.feature_repos.universal.online_store_creator import (
Expand All @@ -11,9 +11,8 @@
class EGMilvusOnlineStoreCreator(OnlineStoreCreator):
def __init__(self, project_name: str, **kwargs):
super().__init__(project_name)
self.container = DockerContainer("mbackes/milvus:2.4.13").with_exposed_ports(
"19530"
)
with MilvusContainer("milvusdb/milvus:v2.4.11") as milvus_container:
self.container = milvus_container

def create_online_store(self) -> Dict[str, str]:
self.container.start()
Expand All @@ -23,12 +22,13 @@ def create_online_store(self) -> Dict[str, str]:
wait_for_logs(
container=self.container, predicate=log_string_to_wait_for, timeout=60
)
exposed_port = self.container.get_exposed_port("19530")
host = self.container.get_container_host_ip()
exposed_port = self.container.get_exposed_port(self.container.port) in self.container.get_connection_url()

return {
"alias": "default",
"type": "eg-milvus",
"host": "localhost",
"host": host,
"port": str(exposed_port),
"username": "user",
"password": "password",
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
"pytest-mock==1.10.4",
"pytest-env",
"Sphinx>4.0.0,<7",
"testcontainers==4.4.0",
"testcontainers[milvus]==4.8.2",
"python-keycloak==4.2.2",
"pre-commit<3.3.2",
"assertpy==1.1",
Expand Down

0 comments on commit d7db708

Please sign in to comment.