feat: TTL support for ScyllaDB config and FeatureViews #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabarn
changed the title
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Nov 7, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Nov 7, 2024
EXPEbdodla
reviewed
Nov 7, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Nov 7, 2024
EXPEbdodla
reviewed
Nov 7, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Nov 7, 2024
EXPEbdodla
reviewed
Nov 8, 2024
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Nov 8, 2024
sdk/python/feast/feature_view.py
Outdated
| Returns: | ||
| An integer representing the TTL in seconds, or None if not set. | ||
| """ | ||
| ttl_str = self.tags.get("online_store_ttl") |
There was a problem hiding this comment.
Change the tag name to online_store_key_ttl_seconds. For easy to remember and align with feature_store.yaml configuration.
EXPEbdodla
reviewed
Nov 8, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Bhargav Dodla <[email protected]>
EXPEbdodla
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds TTL support at the feature_store.yaml level, as well as at the FeatureView level when using ScyllaDB as the online store.
Which issue(s) this PR fixes:
https://jira.expedia.biz/browse/EAPC-15031
Misc