feat: Adding range query request and response proto #181
Conversation
| ASC = 1; | ||
|
|
||
| // Sort results in reverse order as defined by the ordering within the feature store. | ||
| DESC = 2; |
There was a problem hiding this comment.
ASC/DESC don't make sense in this context, they user could have defined multiple keys with differing default sort orders. This might be better as a "reverse sort order" boolean flag.
There was a problem hiding this comment.
Agree. I added that boolean flag to the GetOnlineFeaturesRequest message.
|
Should we update the GrpcServer.Proto too here with GetOnlineFeaturesRange etc..? I know we are not supporting GRPC yet and I think Vineet is working on it, but when we enable it in the future, it will be supported for Range queries endpoint too and we don't have to come back to make changes again. Just a thought, but up to you. |
This will be in another PR, the one for the actual go grpc server implementation. |
What this PR does / why we need it:
This PR adds the protos for the new range query feature server endpoint's request and response. It is needed for the implementation of the new endpoint.
Which issue(s) this PR fixes:
Misc