Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CircleCI config file #5

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Mar 1, 2022

  • Adds a CircleCI config file
  • Does npm test and npm run build

For #4

@kienstra
Copy link
Contributor Author

kienstra commented Mar 1, 2022

Hi @ikovac,
As mentioned, here's a PR to set up CircleCI.

getlocalci#1 shows the jobs passing.

Will package.json have a lint script, maybe with eslint or prettier?

If so, this could run it with:

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 81cbbef..83ce87a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -7,5 +7,7 @@ workflows:
   test-lint:
     jobs:
       - node/test
+      - node/run:
+          npm-run: lint
       - node/run:
           npm-run: build

@kienstra kienstra marked this pull request as ready for review March 1, 2022 02:01
@ikovac
Copy link
Contributor

ikovac commented Mar 11, 2022

@kienstra Yeah, the plan is to add eslint: #3. I will add eslint rule after I finish that ticket.
Thank you for your work!

@ikovac ikovac merged commit cd31ec6 into ExtensionEngine:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants