-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgentPython capture external constants. #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test for
TEST2: typing.Final = some_user_defined_func()
The expected result of this is that it should inspect the function and assign a value.
54e8b9d
to
2a50012
Compare
Co-authored-by: Peter Heywood <[email protected]>
Had to tweak many of the existing tests to prevent unwanted constexpr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tests all pass under linux (and existing codegen tests)
This variant has been tested on both 3.8.13 and 3.10.12
This variant has been tested on both 3.8.13 and 3.10.12
This variant has been tested on both 3.8.13 and 3.10.12
This variant has been tested on both 3.8.13 and 3.10.12
This variant has been tested on both 3.8.13 and 3.10.12
* BugFix: AgentPython was missing ID->id_t type conversion. Improved detail in various codgen exceptions too. * BugFix: #1147 broke Python 3.8.13 This variant has been tested on both 3.8.13 and 3.10.12
converts to
todo
codegen()
to make global varsconstexpr
? (if a user passes in a string)inspect.get_attributes()
(Its python 3.10+, can be emulated viainspect.get_members()
)Closes #1144