Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpplint 2 fixes #1245

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Cpplint 2 fixes #1245

merged 5 commits into from
Nov 19, 2024

Conversation

ptheywood
Copy link
Member

@ptheywood ptheywood commented Nov 5, 2024

  • Suppress <filesystem> warnings
  • Suppress namespace indenting warnings which are incorrect
  • Fix some whitespace warnings
  • Suppress whitespace warnings in macros that would result in a change of __LINE__ behaviour in macros
  • Fix missing include warnings

Closes #1241

@mondus
Copy link
Member

mondus commented Nov 6, 2024

Added missing includes but error on my local machine

FLAMEGPU2\include\flamegpu/detail/cuda.cuh(121): error : identifier "cuCtxGetId" is undefined

Which is odd as I am on CUDA 12.3. Pushing for now as I have run out of time. Might just be my system.

@ptheywood
Copy link
Member Author

12.0 and 12.3 on linux locally for me are fine with your changes, so assuming it's an msvc/your machine issue.

More importantly all_lint passes now with cpplint 2, so assuming windows CI passes this is good to merge IMO.

@Robadob (or @mondus) will have to do the formal review on GH, as I'm unable to as the original PR author (though I can skip the checks anyway)

@ptheywood ptheywood marked this pull request as ready for review November 6, 2024 17:34
Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example builds for me locally (Windows, Debug, Vis=OFF, Seatbelts=ON, CUDA 12.1)

Lint flamegpu/tests both pass locally too.

@ptheywood ptheywood mentioned this pull request Nov 18, 2024
11 tasks
@ptheywood ptheywood merged commit c347616 into master Nov 19, 2024
26 checks passed
@ptheywood ptheywood deleted the cpplint-2-fixes branch November 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpplint 2.x
3 participants