BugFix: Resolve race condition during graph visualisation init.#1350
Merged
Conversation
Robadob
force-pushed
the
bugfix_graph_vis_race
branch
from
f1160f8 to
496baf9
Compare
ptheywood
approved these changes
Nov 19, 2025
Member
ptheywood
left a comment
ptheywood
left a comment
There was a problem hiding this comment.
Looks sensible
(I've not got the problem case to test this, and we don't have automated testing of vis)
|
I've tried the updated version, compiling with |
mondus
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing mutex lock when a graph is first linked to visualisation.
Reported by @DavidFletcherShef in FLAMEGPU/FLAMEGPU2-docs#189 (comment)
CI failures appear to be due to GitHub outage, 500 internal server error during repo fetches.