added copyrights to the signin page #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryabyte21
commented
Apr 14, 2022
aryabyte21
commented
|
@jennydaman, @PintoGideon please review this. |
Signed-off-by: AryaArunB <[email protected]>
jennydaman
requested changes
Apr 20, 2022
src/components/SignIn/SignIn.jsx
Outdated
| @@ -150,10 +150,17 @@ export class SignIn extends Component { | |||
| <Link to="/quickstart" href="/quickstart"> | |||
| Signup | |||
| </Link> | |||
| <div className="footer-copyright" style={{color:"white"}}> | |||
There was a problem hiding this comment.
Using the CSS class footer-copyright here is a bad practice, while it's true that CSS classes are global, we would like to have some notion of scope. I would suggest either moving the class out of src/components/Footer/Footer.css and to some other CSS file which is explicitly designated to contain global classes, or copy the class to SignIn.css
There was a problem hiding this comment.
Scoping would protect against a fix for #151 (which enforces scoping)
There was a problem hiding this comment.
Thanks for the feedback @jennydaman I have copied the class to SignIn.css
Signed-off-by: AryaArunB <[email protected]>
|
@jennydaman is there something more that you'd like me to do in this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.