Fix Calendar #202
Fix Calendar #202
Conversation
There was a problem hiding this comment.
Thanks for the contribution!
I attached some specific review comments to clarify parts of the diff, but a bigger issue I noticed is that generating the calendar feed with your modifications didn't decrease the number of errors reported by the ICS validator. I think you bring up some interesting changes to formatting and escaping of information, but I think more work may be needed to fully solve the issue.
I poked around a little bit and I suspect the majority of the errors are related to lacking a VTIMEZONE block in the file that defines what America/New_York means (it seems to be treated as simply a unique identifier, despite the identifier chosen being confusingly similar to the way timezones are defined per standard).
I suspect this is the point where bringing in a library to handle the timezones is the best course of action - open to any recommendations you may have for libraries!
Thanks again for the contribution!
| # --- calendar feed settings --- | ||
| calendar_feed: | ||
| url: "https://fossrit.github.io/feeds/calendar.ics" | ||
| description: "Upcoming FOSS@RIT events in iCalendar format" | ||
| timezone: "America/New_York" | ||
|
|
There was a problem hiding this comment.
Are these settings associated with a particular jekyll plugin? They dont seem to be referred to in the calendar.ics file and i dont see any similarly named plugins in Gemfile or _config.yaml that would indicate what these parameters are doing.
| URL:{{post.redirect}}{% elsif post.categories.last != "meetings-meetups" %} | ||
| URL:{{site.url}}{{site.baseurl}}{{post.url}}{% else %} | ||
| URL:{{site.url}}{{site.baseurl}}/get-involved{% endif %}{% if post.categories.last == "meetings-meetups" %} |
There was a problem hiding this comment.
Is there a reason why these variations on the URL were removed? The warnings from the RFC checker were mostly timezone and line length related, so I'm not seeing a reason to change this
| CATEGORIES:{{site.title-abbrev}},{{site.title}},{{post.categories.last | upcase}}{% else %} | ||
| CATEGORIES:{{site.title-abbrev}},{{site.title}},{{post.categories.first | upcase}}{% endif %} |
There was a problem hiding this comment.
Same thing here - Is there a reason these lines were changed?
I just fixed the calendar for this project. I hope it is useful for you.