Fixing the test and added a PR trigger#650
Merged
cavearr merged 5 commits intoFPGAwars:developfrom Jun 25, 2025
Merged
Conversation
…g on it in followup commits.
Collaborator
Author
|
@Obijuan, I see that the automatic test was triggered on this PR. That's good. Please let it complete before you accept. Hopefully we will have now a safer PR process. |
Collaborator
Author
|
The windows tests are significantly slower than the mac and linux. I am not sure why but other people reported the same. |
Member
|
Thanks @zapta ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Obijuan, please review and accept.
Added a trigger to run the tests on future PRs.
Relaxed a too strict assertion that failed the test.