Add module version to compiled module-info #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebemish
added a commit
to lukebemish/FancyModLoader
that referenced
this pull request
Aug 25, 2025
…work in cases where mixin is modular or not Depends on FabricMC/Mixin#184
LlamaLad7
approved these changes
Aug 25, 2025
Juuxel
approved these changes
Aug 25, 2025
Member
Juuxel
left a comment
Juuxel
left a comment
There was a problem hiding this comment.
This is a good thing to include in general to have a more complete module-info IMO
modmuss50
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are attempting to make use of compat-level annotations for mixin configs in neoforge (see neoforged/FancyModLoader#339) but with how we are structuring this, need the currently-running fabric mixin version at runtime to determine the maximum mixin version a mod should be able to request the equivalent compat to. We cannot use
Package#getImplementationVersionto get this in all cases, because in a neo context, mixin may be running as a module and packages in modules do not have spec/impl versions attached. An easy solution is to attach the version to the module-info such that it can be retrieved from the module at runtime.