Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment4 Ignacio Garcia Luengo #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Assignment4 Ignacio Garcia Luengo #99

wants to merge 4 commits into from

Conversation

IgnacioGarciaLuengo
Copy link
Contributor

Ya lo entregué hace tiempo pero me equivoqué de repositorio e hice el pul request al de mi compañero de práctica, ruego disculpe las molestias y lo tenga en cuenta para el retraso de la práctica

@ocorcho
Copy link
Member

ocorcho commented Dec 14, 2021

Assignment 3 is ok, now @dgarijo can check assignment 4

Copy link
Contributor

@dgarijo dgarijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the small issues detected

print(s,p,o)

university = Namespace("http://University#")
g.add((university.University, RDF.type, RDFS.Class))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you add it twice?

**Task 07: Querying RDF(s)**
"""

!pip install rdflib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in Python, you need to comment it out

initNs={"RDFS": RDFS, "ns": ns, "RDF": RDF}
)

for person in personas:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop is quite confusing. You are already getting the right results from the query. Why combine it with rdf lib here? the rdf lib and the query parts of the exercise should be separate

@ocorcho
Copy link
Member

ocorcho commented Dec 20, 2021

No se han modfiicado los cambios solicitados por Daniel, así que la calificación será de 5 sobre 10 en la evaluación continua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants