chore: build Arm64 binary #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlaltf24
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Needs a build matrix to run the build twice, as-is it's telling GHA that either are acceptable runners when really we meant run the build twice, one for each
https://www.blacksmith.sh/blog/matrix-builds-with-github-actions
|
Great—thanks for confirming what's proper for me. I will look to update soon. |
|
How would I test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238. Adds a runner matrix to build Arm64 binaries.
The main purpose of this PR at the moment is to be better able to test what is needed for running Logos x86_64 through an ELF interpreter for Arm. At present we have to run both OD and Logos through the ELF interpreter. The goal of this is to be passing only Logos through the ELF interpreter.