Fix backup cli #345
Fix backup cli #345
Conversation
|
We might need/want to backup/restore Logos registry keys, as well as user data folders. |
| bar += str(d*d_ct) | ||
| bar += suffix #+ end | ||
| return bar | ||
|
|
||
| # De-dup | ||
| if message != self._last_status: |
There was a problem hiding this comment.
Should the bar print even if the status didn't change?
We may consider changing the Downloading.... status to use a percentage instead of adding dots
ou_dedetai/control.py
Outdated
| from pathlib import Path | ||
|
|
||
| from ou_dedetai.app import App | ||
|
|
||
| from . import system | ||
| from . import utils | ||
| # from . import utils |
ou_dedetai/backup.py
Outdated
| while t.is_alive(): | ||
| i += 1 | ||
| i = i % 20 | ||
| app.status(f"{message}{"." * i}\r") |
There was a problem hiding this comment.
nit: use progress in status rather than adding dots
ou_dedetai/backup.py
Outdated
| if mode == 'restore': | ||
| if not app.conf.logos_exe: | ||
| app.exit("Cannot restore, Logos is not installed") | ||
| dst_dir = Path(app.conf.logos_exe).parent |
There was a problem hiding this comment.
Should this use logos app data Dir instead?
There was a problem hiding this comment.
I had the same question, but I think the Logos app should be installed before trying to restore a backup. Otherwise installing Logos over existing data directories might clobber them? Not sure. Also, is app.conf.logos_exe generic enough to be defined as the Verbum exe path as well?
|
Consider a file chooser for setting Backup dir: |
Get backup and restore working for CLI (prep for getting general backup/restore working)