fix: fix UserTraits type in analytics

This fixes the `UserTraits` type in analytics to allow the user to specify properties that lives in either one of the types that compose the union. For example, `countryCode` only exists in `User` type but I cannot create a new variable typed `UserTraits` that contains the `countryCode` property with the current type. This change will allow that
Farfetch · May 23, 2023 · aae0757 · aae0757
1 parent ae91f5d
commit aae0757
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/analytics/src/types/analytics.types.ts b/packages/analytics/src/types/analytics.types.ts
@@ -94,7 +94,7 @@ export type ExtendedTrackTypes =
   | typeof ON_SET_USER_TRACK_TYPE
   | typeof LOAD_INTEGRATION_TRACK_TYPE;
 
-export type UserTraits = Omit<User | UserLegacy, 'id'>;
+export type UserTraits = Omit<User, 'id'> | Omit<UserLegacy, 'id'>;
 
 export type UserData = {
   id: number | null | undefined;

diff --git a/packages/analytics/src/utils/hashUserData.ts b/packages/analytics/src/utils/hashUserData.ts
@@ -38,7 +38,7 @@ const hashUserData = (userData: UserData): UserData => {
           name: hashPlainTextString(traits.name) as string,
           phoneNumber: hashPlainTextString(traits.phoneNumber),
           username: hashPlainTextString(traits.username) as string,
-        },
+        } as UserTraits,
       };
     }