Enforce nullability at deserialization time (issue #373) #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know which Exception should be used here |
|
|
||
| inline fun <reified T> T.throwIfNullableTypeIsNull(): T { | ||
| if (null !is T && this == null) { | ||
| throw Exception() |
There was a problem hiding this comment.
This is bit tricky because failure happens outside of call that has DeserializationContext -- usually you'd call context.reportInputMismatch(...) (or similar). That throws MismatchedInputException, for what that is worth.
That is used by databind. Might be worth checking how Kotlin module indicates errors however.
@dinomite and @viartemev can give more guidance (and would be ones reviewing this, indicating whether approach makes sense to them)
dinomite
changed the title
|
Closing in favor of 405 which is based upon 2.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.