Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added precommit feature #273

Closed
wants to merge 11 commits into from
Closed

Added precommit feature #273

wants to merge 11 commits into from

Conversation

Sukriti-sood
Copy link
Contributor

fixes #248

Added precommit features but There is some confusion , I have added husky inside period folder as package.json was inside.

@vercel
Copy link

vercel bot commented May 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/feminine-divin/period/GYrjY3tZKnpyGbjCUogKzA4vxmDz
✅ Preview: Failed

@khushishikhu khushishikhu added gssoc21 Issues for GirlSript Summer of Code Level2 Bug Fixing, Adding small features labels May 8, 2021
Khushi-24 and others added 4 commits May 13, 2021 15:14
@Khushi-24
docs(CONTRIBUTING.md): Added instructions for rebasing - #268 (#269)
ad469d0
@A-HK
Created User Profile Page (#272)
817fe42 
* about page addition

* sticky-nav

* Navbar made sticky

* Images made Responsive

* Images made responsive final

* end card added

* made nav sticky again

* Prescriptions based on Quiz Results added

* feat: Created profile page - #67

Signed-off-by: A-HK <[email protected]>

* feat: Created user profile page - #67

Signed-off-by: A-HK <[email protected]>
@gnikita432
bug: fixed flow page bug in mobile view -#271 (#277)
7be82ea
@gnikita432
bug: Set up responsive button in calender - #258 (#270)
98d2398
@Aaishpra Aaishpra requested a review from K-Kumar-01 May 13, 2021 09:47
@garvitgupta13
Added validation to gynac-form (#281)
7d670ff 
* added validation to gynac-form

* made email as required input
K-Kumar-01
K-Kumar-01 reviewed May 13, 2021
View reviewed changes
periodo/package.json Outdated
"start": "next start",
"prepare": "husky install",
"prettier": "prettier --write */*.{js,css} --ignore-pattern node_modules/",
"lint": "eslint *.js --ignore-pattern node_modules/"
Copy link
Collaborator

@K-Kumar-01 K-Kumar-01 May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed(Line 11) so that it fixes the error automatically.

periodo/package.json Outdated
Comment on lines 8 to 11
"start": "next start",
"prepare": "husky install",
"prettier": "prettier --write */*.{js,css} --ignore-pattern node_modules/",
"lint": "eslint *.js --ignore-pattern node_modules/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a script setup: "npm i && npm run prepare".
Also document the changes. That is instead of npm i the user should run npm run setup

@vercel
Copy link

vercel bot commented May 14, 2021

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/feminine-divin/settings/billing.

@khushishikhu khushishikhu added Level3 New feature, Major Bug fixing and removed Level2 Bug Fixing, Adding small features labels May 15, 2021
@K-Kumar-01
Copy link
Collaborator

@Sukriti-sood
Please follow the commit guidelines that have been mentioned.

@K-Kumar-01
Copy link
Collaborator

@Sukriti-sood
Also, I am seeing many different files like the rebasing documents. So please also rebase the commits so that I can have a better understanding of your particular changes. In addition, please also remove the merge conflicts.

@Sukriti-sood Sukriti-sood mentioned this pull request May 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Kumar-01 K-Kumar-01 K-Kumar-01 left review comments

Assignees
No one assigned
Labels
gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrating Pre-commit hook
7 participants
@Sukriti-sood @K-Kumar-01 @khushishikhu @Khushi-24 @A-HK @gnikita432 @garvitgupta13