Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buscador de usuarios por nombre en github #41

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions mauricio/githubSearch/css/style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
body {
font-family: 'Roboto', sans-serif;
}

h1 {
text-align: center;
}

.container {
max-width: 1200px;
margin: auto;
}

.logo {
max-width: 2.5rem;
vertical-align: sub;
}

input {
margin: 0 auto 3.125rem;
display: block;
font-size: 1.875rem;
padding: 0.3125rem 0.9375rem;
border: 0.125rem solid #355C7D;
}

p {
text-align: left;
margin: 0;
}

ul {
width: 620px;
margin: 0 auto 0;
list-style-type: none;
padding: 1.25rem 1.25rem 0.3125rem 1.25rem;
color: #fff;
}

ul li {
margin: 0.45rem 0 1.75rem 0;
position: relative;
padding: 20px 4.0625rem 20px 110px;
font-size: 1.25rem;
background-color: #355C7D;
}

ul li a {
display: block;
}

ul li img {
width: 3.5rem;
height: 3.5rem;
position: absolute;
left: 4%;
top: 50%;
transform: translate(0%, -50%);
border-radius: 50%;
border: 0.125rem solid #F8B195;
padding: 0.125rem;
}

div .user-details {
display: table;
width: 100%;
margin-top: 0.3125rem;
}

div .user-details div {
display: table-cell;
width: 35%;
font-size: 1rem;
}

.p-username {
font-weight: 700;
margin-bottom: 0.3125rem;
}

span {
font-weight: 300;
}
Binary file added mauricio/githubSearch/img/github.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions mauricio/githubSearch/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!DOCTYPE html>
<html lang="es">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Document</title>
<link href="https://fonts.googleapis.com/css?family=Roboto:400,700" rel="stylesheet">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/normalize/8.0.1/normalize.min.css"/>
<link rel="stylesheet" href="css/style.css" type="text/css"/>
</head>
<body>

<div class="container">
<h1>Search by username <img class="logo" src="img/github.png"></h1>

<input type="text" id="input" placeholder="Eric Elliott"/>
</div>

<script type="text/javascript" src="js/main.js"></script>
</body>
</html>

112 changes: 112 additions & 0 deletions mauricio/githubSearch/js/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podría ser arrow...


const input = document.querySelector('input');
input.addEventListener('keyup', searchUser, false);
const container = document.querySelector('.container');

async function searchUser($event) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el naming de $event fuera de angular.. no es muy extendido ;-)


try {
if ($event.code === 'Enter' && $event.isTrusted) {

if (!input.value.trim()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto lo reutilizas luego como text..


const p = document.createElement('P');
container.appendChild(p);
p.textContent = 'Please enter username';
return false;

} else {

const isUl = document.querySelector('ul') !== null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es raro como manejas este condicional y su contexto con document.querySelector('ul') e isUl


if (isUl) {
document.querySelector('ul').remove();
}

const text = input.value.trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ cuidado con el Hoisting


const response = await callApi(`https://api.github.com/search/users?q=${text}+in%3Afullname&type=Users`);
generateUserList(response);

}
}
} catch (error) {
console.log(error);
}

}

function ajax(url) {
return new Promise((resolve, reject) => {
fetch(url)
.then(response => {
if (response.status === 200) {
resolve(response.json())
} else {
reject(response.json());
}
})
.catch(error => console.log(error));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui haces un return raro...

})
}

async function callUserProfile(url) {
try {
return await ajax(url);
} catch (error) {
console.log(error);
}
}

async function callApi(url) {
try {
return await ajax(url);
} catch (error) {
console.log(error);
}
}

function generateUserList(data) {
const ul = document.createElement('UL');
container.appendChild(ul);

const resArray = data.items;

resArray.forEach(async function (item) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no es mas sencillo un Promise.All()?

try {
const urls = item.url;
const netWorking = await callUserProfile(urls);
const div = makeTemplate(item, netWorking);
ul.insertAdjacentHTML('afterbegin', div);
} catch (error) {
console.log(error);
}

})
}

function makeTemplate(item, netWorking) {
const template = `
<li>${item.login}
<a href="${item.html_url}" target="_blank">
<img src="${item.avatar_url}">
</a>
<div class="user-details">
<div>Score:
<span>${item.score.toFixed(2)}</span>
</div>
<div>
<span>Followers: ${netWorking.followers}</span>
</div>
<div>
<span>Followings: ${netWorking.following}</span>
</div>
</div>
</li>
`;

return template;
}

})();