Skip to content

Conversation

@wjmelements
Copy link
Contributor

Reviewer @rvagg
This reduces storage accumulation.
However the piece metadata will still not be removed when the whole data set is deleted.

Changes

  • rm piece metadata in piecesScheduledRemove

@wjmelements wjmelements requested a review from rvagg November 5, 2025 17:40
@FilOzzy FilOzzy added this to FS Nov 5, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Nov 5, 2025
@wjmelements wjmelements requested a review from Kubuxu November 5, 2025 17:55
@rvagg
Copy link
Collaborator

rvagg commented Nov 5, 2025

There's a missing window here though, piece won't actually be removed from data set until the nextProvingPeriod is called on that data set. So now we have a piece with no metadata - user, or others, will list pieces in a data set, see them, but with nothing about them.

Not a great state of affairs. Would it be practical to extend PDPListener#nextProvingPeriod to pass through uint256[] removals? I wonder if that could get too big to pass as an argument there...

@rjan90 rjan90 moved this from 📌 Triage to ⌨️ In Progress in FS Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ⌨️ In Progress

Development

Successfully merging this pull request may close these issues.

3 participants