Skip to content

Feature #1113 - SQL Schemas #8445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Feature #1113 - SQL Schemas #8445

wants to merge 21 commits into from

Conversation

asfernandes
Copy link
Member

No description provided.

@asfernandes asfernandes linked an issue Feb 21, 2025 that may be closed by this pull request
@dyemanov dyemanov self-requested a review February 25, 2025 11:58
@asfernandes
Copy link
Member Author

Can someone please review this?
It will certainly require more work, and also there is compatibility work necessary to be done at least in v5 branch.

Copy link
Member

@hvlad hvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just for docs, I'll try to add more reviews of the code later


```sql
ALTER SCHEMA <schema name>
<alter schema option>...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear if more than one option is allowed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ... makes it clear that it is.

The monitoring tables now include schema-related information:

`MON$ATTACHMENTS`
- `MON$SEARCH_PATH`: search path of the attachment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEARCH_PATH looks too generic, may be SCHEMA_SEARCH_PATH should be used ?
Or SCHEMA_PATH for short ?

Of course, if changed, it should be the same everywhere: context variable, DPB tag names, utilities command-line switches, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL standard has SET SEARCH_PATH command.
In docs, I tried to always call it schema search path.
In this case, I used same wording as the command.

-- SCHEMA2
-- schema3
-- "schema 4"
-- "schema "5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- "schema "5"" ? Looks like last double quote is missed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it closes the double-quote started at "schema .

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Apr 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SQL Schemas [CORE738]
3 participants