fix: certain islands not being correctly identified as modern#2290
Open
Wapic wants to merge 1 commit intoFirmamentMC:mc-1.21.11from
Open
fix: certain islands not being correctly identified as modern#2290Wapic wants to merge 1 commit intoFirmamentMC:mc-1.21.11from
Wapic wants to merge 1 commit intoFirmamentMC:mc-1.21.11from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent Hub change a lot of islands now use 1.21 eye height making Etherwarp overlay incorrect on those islands.
I added some missing islands, sorted them by category, and refactored
isModernServerto include the islands which have been affected by the update.Haven't tested Jerry's Workshop since it is currently not available.
More islands are bound to be changed in the future but these are correct for now