Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial work to separate task processor from main repository #1

Merged
merged 20 commits into from
Feb 12, 2024
Merged

feat: initial work to separate task processor from main repository #1

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0eef3fb
Initial work to separate task processor from main repository
matthewelwell Jan 19, 2024
8932e74
Fix workflow
matthewelwell Jan 19, 2024
e36e79c
Add pointless __init__ file
matthewelwell Jan 19, 2024
aa6f02e
Remove pointless __init__ file
matthewelwell Jan 19, 2024
e1546ea
Loosen Django dependency
matthewelwell Jan 30, 2024
89082cd
Update readme wording and example
matthewelwell Jan 30, 2024
538413a
typing.Optional -> `|`
matthewelwell Jan 30, 2024
58610fa
Add comment to seemingly unused import.
matthewelwell Jan 30, 2024
9b8f17e
Add TODO
matthewelwell Jan 30, 2024
7d469ae
Remove unnecessary typing import
matthewelwell Jan 30, 2024
93b141e
Add typing to managers module
matthewelwell Jan 30, 2024
fc82670
Formatting
matthewelwell Jan 30, 2024
52fb316
Refactor helpers
matthewelwell Jan 30, 2024
b422789
Add __init__.py
matthewelwell Feb 2, 2024
1016207
Explicitly include sql files
matthewelwell Feb 2, 2024
5de1083
More pyproject changes
matthewelwell Feb 2, 2024
1fd3176
re-add __init__ and change pyproject include
matthewelwell Feb 2, 2024
20e2723
change include definition
matthewelwell Feb 2, 2024
1152d0b
Add build-system
matthewelwell Feb 2, 2024
cf373be
Add return types to manager methods
matthewelwell Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions task_processor/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@


class TaskManager(Manager):
def get_tasks_to_process(self, num_tasks):
def get_tasks_to_process(self, num_tasks: int):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing return type here and below

return self.raw("SELECT * FROM get_tasks_to_process(%s)", [num_tasks])


class RecurringTaskManager(Manager):
def get_tasks_to_process(self, num_tasks):
def get_tasks_to_process(self, num_tasks: int):
return self.raw("SELECT * FROM get_recurringtasks_to_process(%s)", [num_tasks])
Loading