Skip to content

Commit

Permalink
fix: Show "Clear all" to the left of feature filters to prevent layou…
Browse files Browse the repository at this point in the history
…t shift (#5143)
  • Loading branch information
rolodato authored Feb 20, 2025
1 parent 37c0878 commit cff5c96
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion frontend/web/components/ClearFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const ClearFilters: FC<ClearFiltersType> = ({ onClick }) => {
return (
<div
onClick={onClick}
className='fw-semibold cursor-pointer text-primary d-flex align-items-center ms-2 gap-1'
className='fw-semibold cursor-pointer text-primary d-flex align-items-center mx-3 gap-1'
>
<IonIcon className='h6 mb-0' color='#6837fc' icon={closeCircle} />
Clear all
Expand Down
6 changes: 3 additions & 3 deletions frontend/web/components/pages/FeaturesPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,9 @@ const FeaturesPage = class extends Component {
value={this.state.search}
/>
<Row className='flex-fill justify-content-end'>
{hasFilters && (
<ClearFilters onClick={clearFilters} />
)}
<TableTagFilter
useLocalStorage
isLoading={FeatureListStore.isLoading}
Expand Down Expand Up @@ -526,9 +529,6 @@ const FeaturesPage = class extends Component {
this.setState({ sort }, this.filter)
}}
/>
{hasFilters && (
<ClearFilters onClick={clearFilters} />
)}
</Row>
</div>
</Row>
Expand Down
6 changes: 3 additions & 3 deletions frontend/web/components/pages/UserPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,9 @@ const UserPage: FC<UserPageType> = (props) => {
value={filter.search}
/>
<Row className='flex-fill justify-content-end'>
{hasFilters && (
<ClearFilters onClick={clearFilters} />
)}
<TableTagFilter
projectId={projectId}
className='me-4'
Expand Down Expand Up @@ -609,9 +612,6 @@ const UserPage: FC<UserPageType> = (props) => {
})
}}
/>
{hasFilters && (
<ClearFilters onClick={clearFilters} />
)}
</Row>
</div>
</Row>
Expand Down

0 comments on commit cff5c96

Please sign in to comment.