fix(organisation): allow Organisation delete when committed change request present #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
khvn26
approved these changes
Feb 13, 2025
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5101 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 1214 1214
Lines 42312 42327 +15
=======================================
+ Hits 41228 41243 +15
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix/allow-change-request-delete-for-deleted-project
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue deleting an organisation when a committed change request exists in any project / environment in that organisation.
This was previously not an issue because of the line which checked if the environment was deleted but, now that we've linked the project, the cascade delete is triggered from the project, before it deletes the environment, and hence the check failed and the exception was raised.
How did you test this code?
Added unit test.