Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce --name/-n argument in makemigrations management command #5107

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

matthewelwell
Copy link
Contributor

Changes

Enforces the use of --name/-n when creating migrations.

How did you test this code?

Ran makemigrations with and without --name/-n and verified the correct result.

@matthewelwell matthewelwell requested a review from a team as a code owner February 14, 2025 16:02
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team February 14, 2025 16:02
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 0:26am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 0:26am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 0:26am

@github-actions github-actions bot added the api Issue related to the REST API label Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5107 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5107 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5107 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5107 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5107 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5107 Finished ✅ Results

@github-actions github-actions bot added the chore label Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Uffizzi Preview deployment-60941 was deleted.

@khvn26
Copy link
Member

khvn26 commented Feb 14, 2025

Looks like this breaks the --check check in CI.

@matthewelwell
Copy link
Contributor Author

Allow dry-run / check

Yeah, fixed in 2689d5e

@github-actions github-actions bot added chore and removed chore labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (2a13d81) to head (d3e0bcc).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5107   +/-   ##
=======================================
  Coverage   97.43%   97.44%           
=======================================
  Files        1214     1216    +2     
  Lines       42327    42348   +21     
=======================================
+ Hits        41243    41264   +21     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added chore and removed chore labels Feb 14, 2025
@github-actions github-actions bot added chore and removed chore labels Feb 14, 2025
@matthewelwell matthewelwell force-pushed the chore/enforce-name-argument-in-makemigrations branch from cebdde1 to 9924873 Compare February 14, 2025 17:48
@github-actions github-actions bot added chore and removed chore labels Feb 14, 2025
@github-actions github-actions bot removed the chore label Feb 14, 2025
@github-actions github-actions bot added the chore label Feb 14, 2025
@github-actions github-actions bot added chore and removed chore labels Feb 17, 2025
@matthewelwell matthewelwell merged commit 4d033e5 into main Feb 17, 2025
37 checks passed
@matthewelwell matthewelwell deleted the chore/enforce-name-argument-in-makemigrations branch February 17, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants